Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix click-to-open on Windows #5431

Merged
merged 2 commits into from
Oct 14, 2018
Merged

Fix click-to-open on Windows #5431

merged 2 commits into from
Oct 14, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Oct 14, 2018

It looks like #4866 broke it for all releases. Windows paths start with something like C: but the regex doesn't allow : so no path actually passes the check.

Since enabling : everywhere is likely not safe, I specifically enable ([a-ZA-Z]:[/\\])? at a first position instead.

@gaearon gaearon merged commit bd0ffb7 into master Oct 14, 2018
@gaearon gaearon deleted the gaearon-patch-2 branch October 21, 2018 20:00
@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants